From 33964ca6d1410a655631676a675ea6c4bc6e39ad Mon Sep 17 00:00:00 2001
From: powermaker450 <contact@povario.com>
Date: Tue, 27 Aug 2024 01:19:50 -0400
Subject: [PATCH] Use static methods for responder and export the whole class

---
 src/routes/post.ts     | 10 +++++-----
 src/utils/responder.ts | 14 ++++++--------
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/routes/post.ts b/src/routes/post.ts
index bb5f82b..5cf4941 100644
--- a/src/routes/post.ts
+++ b/src/routes/post.ts
@@ -1,5 +1,5 @@
 import { userReviewSchema, typeJson } from "../types";
-import { Logger, responder, data } from "../utils";
+import { Logger, Responder, data } from "../utils";
 import { Express, Request, Response } from "express";
 
 export class PostListener {
@@ -24,7 +24,7 @@ export class PostListener {
 
           res.writeHead(400, typeJson);
           res.write(
-            responder.JsonError("recieved chunk contains invalid JSON"),
+            Responder.JsonError("recieved chunk contains invalid JSON"),
           );
           res.end();
           return;
@@ -41,14 +41,14 @@ export class PostListener {
                 data.appendReview(validUserReview);
 
                 res.writeHead(201, typeJson);
-                res.write(responder.success("review was sent"));
+                res.write(Responder.success("review was sent"));
                 res.end();
               } catch (err) {
                 this.logger.error("Failed to assign ID to review:", err);
 
                 res.writeHead(500, typeJson);
                 res.write(
-                  responder.serverError("failed to assign ID to review"),
+                  Responder.serverError("failed to assign ID to review"),
                 );
                 res.end();
               }
@@ -59,7 +59,7 @@ export class PostListener {
             this.logger.error(`${sender} <~ ${err}`);
 
             res.writeHead(400, typeJson);
-            res.write(responder.error(err));
+            res.write(Responder.error(err));
             res.end();
           });
       });
diff --git a/src/utils/responder.ts b/src/utils/responder.ts
index dd45658..ca2c21e 100644
--- a/src/utils/responder.ts
+++ b/src/utils/responder.ts
@@ -1,13 +1,13 @@
 import { ValidationError } from "yup";
 
-class Responder {
-  public success(message: string): string {
+export class Responder {
+  public static success(message: string): string {
     return JSON.stringify({
       message: message,
     });
   }
 
-  public error(error: ValidationError): string {
+  public static error(error: ValidationError): string {
     return JSON.stringify({
       error: {
         type: error.name,
@@ -16,7 +16,7 @@ class Responder {
     });
   }
 
-  public serverError(errorMessage: string): string {
+  public static serverError(errorMessage: string): string {
     return JSON.stringify({
       error: {
         type: "InternalError",
@@ -25,7 +25,7 @@ class Responder {
     });
   }
 
-  public requestError(errorMessage: string): string {
+  public static requestError(errorMessage: string): string {
     return JSON.stringify({
       error: {
         type: "RequestError",
@@ -34,7 +34,7 @@ class Responder {
     });
   }
 
-  public JsonError(errorMessage: string): string {
+  public static JsonError(errorMessage: string): string {
     return JSON.stringify({
       error: {
         type: "JsonError",
@@ -43,5 +43,3 @@ class Responder {
     });
   }
 }
-
-export const responder = new Responder();