From 91480fea64d42a3b5af4352fd8e4944d8735ca98 Mon Sep 17 00:00:00 2001
From: powermaker450 <contact@povario.com>
Date: Fri, 13 Sep 2024 12:12:07 -0400
Subject: [PATCH] Return 404 on review ID that returns no review

---
 src/routes/reviews.ts | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/routes/reviews.ts b/src/routes/reviews.ts
index cc10429..bde3d6a 100644
--- a/src/routes/reviews.ts
+++ b/src/routes/reviews.ts
@@ -25,9 +25,15 @@ export class MessagesResponder extends ApiRoute {
       const receiver = req.headers["user-agent"];
       const result = data.getReviewById(req.params.id);
 
-      res.writeHead(200, typeJson);
-      res.write(JSON.stringify(result));
-      res.end();
+      if (Object.keys(result).length) {
+        res.writeHead(200, typeJson);
+        res.write(JSON.stringify(result));
+        res.end();
+      } else {
+        res.writeHead(404, typeJson);
+        res.write(Responder.requestError("review not found"));
+        res.end();
+      }
 
       this.logger.log(`${Logger.emp(receiver)} <~ "${req.path}"`);
     });