From e097ed69a7fd80d6924cec916048a15bcce04402 Mon Sep 17 00:00:00 2001
From: powermaker450 <contact@povario.com>
Date: Mon, 19 Aug 2024 01:46:06 -0400
Subject: [PATCH] Assign ID's to reviews for use server-side

---
 src/main.ts            | 36 ++++++++++++++++++++++++------------
 src/types.ts           | 12 +++++++++---
 src/utils/functions.ts | 21 ++++++++++++++++++---
 src/utils/responder.ts |  9 +++++++++
 4 files changed, 60 insertions(+), 18 deletions(-)

diff --git a/src/main.ts b/src/main.ts
index 2848abd..7428cbf 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -1,8 +1,8 @@
 import fs from "fs";
 import http from "http";
 import dotenv from "dotenv";
-import { Review, reviewSchema } from "./types";
-import { bold, checkFile, emp, Logger, Responder } from "./utils";
+import { serverReviewSchema, ServerSideReview, userReviewSchema } from "./types";
+import { appendId, bold, checkFile, emp, Logger, Responder } from "./utils";
 dotenv.config();
 
 const logger = new Logger("Simple Review Server");
@@ -19,7 +19,7 @@ http
 
     req.on("data", async (chunk) => {
       if (req.url === "/post") {
-        let data: Review[] = checkFile("data.json", "utf8");
+        let data: ServerSideReview[] = checkFile("data.json", "utf8");
         let temp: any;
 
         try {
@@ -33,21 +33,33 @@ http
           return;
         }
 
-        await reviewSchema
+        await userReviewSchema
           .validate(temp)
           .then((valid) => {
             req.on("end", () => {
               logger.log(`${sender} ~>`, valid);
 
-              data.push(valid);
-              fs.writeFileSync(
-                "./persist/data.json",
-                JSON.stringify(data, null, 2),
-              );
+            serverReviewSchema
+              .validate(appendId(valid))
+              .then((valid) => {
+                data.push(valid);
+                fs.writeFileSync(
+                  "./persist/data.json",
+                  JSON.stringify(data, null, 2),
+                );
+
+                res.writeHead(201, contentType);
+                res.write(response.success("review was sent"));
+                res.end();
+              })
+              .catch((err) => {
+                logger.error("Failed to assign ID to review:", err);
+
+                res.writeHead(500, contentType);
+                res.write(response.serverError("could not assign ID to review"));
+                res.end();
+              });
 
-              res.writeHead(201, contentType);
-              res.write(response.success("review was sent"));
-              res.end();
             });
           })
           .catch((err) => {
diff --git a/src/types.ts b/src/types.ts
index 45a3ce8..826a72c 100644
--- a/src/types.ts
+++ b/src/types.ts
@@ -1,7 +1,7 @@
 import { object, string, number, InferType } from "yup";
 
-export const reviewSchema = object({
-  username: string().max(30).required(),
+export const userReviewSchema = object({
+  username: string().min(2).max(30).required(),
   rating: number()
     .positive()
     .max(5)
@@ -15,4 +15,10 @@ export const reviewSchema = object({
   content: string().max(2000).notRequired(),
 });
 
-export type Review = InferType<typeof reviewSchema>;
+export const serverReviewSchema = userReviewSchema.shape({
+  id: string().length(6).required()
+})
+
+export type UserSideReview = InferType<typeof userReviewSchema>;
+
+export type ServerSideReview = InferType<typeof serverReviewSchema>;
diff --git a/src/utils/functions.ts b/src/utils/functions.ts
index 07ca094..1458aba 100644
--- a/src/utils/functions.ts
+++ b/src/utils/functions.ts
@@ -1,10 +1,10 @@
 import fs from "fs";
-import { Review } from "../types";
+import { serverReviewSchema, ServerSideReview, UserSideReview } from "../types";
 
-export function checkFile(file: string, encoding: fs.EncodingOption): Review[] {
+export function checkFile(file: string, encoding: fs.EncodingOption): ServerSideReview[] {
   const dir = "./persist/";
   const fullPath = dir + file;
-  let final: Review[];
+  let final: ServerSideReview[];
 
   if (fs.existsSync(dir)) {
     const data = fs.readFileSync(fullPath, encoding);
@@ -18,3 +18,18 @@ export function checkFile(file: string, encoding: fs.EncodingOption): Review[] {
 
   return final;
 }
+
+// Generates a unique 6-character ID
+export function generateId(): string {
+  return Math.random().toString(36).replace("0.", "").substring(0, 6);
+}
+
+export function appendId(userReview: UserSideReview): ServerSideReview {
+  return {
+    rating: userReview.rating,
+    username: userReview.username,
+    title: userReview.title,
+    content: userReview.content,
+    id: generateId()
+  };
+}
diff --git a/src/utils/responder.ts b/src/utils/responder.ts
index badc5d7..a17f4df 100644
--- a/src/utils/responder.ts
+++ b/src/utils/responder.ts
@@ -18,6 +18,15 @@ export class Responder {
     });
   }
 
+  public serverError(errorMessage: string): string {
+    return JSON.stringify({
+      error: {
+        type: "InternalError",
+        message: errorMessage
+      }
+    });
+  }
+
   public requestError(errorMessage: string): string {
     return JSON.stringify({
       error: {