powermaker450/simple-review-server
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Return 404 on review ID that returns no review

Browse source
This commit is contained in:
powermaker450 2024-09-13 12:12:07 -04:00
parent 14e9549599
commit 91480fea64
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/routes/reviews.ts
View file

@ -25,9 +25,15 @@ export class MessagesResponder extends ApiRoute {
const receiver = req.headers["user-agent"];
const result = data.getReviewById(req.params.id);
res.writeHead(200, typeJson);
res.write(JSON.stringify(result));
res.end();
if (Object.keys(result).length) {
res.writeHead(200, typeJson);
res.write(JSON.stringify(result));
res.end();
} else {
res.writeHead(404, typeJson);
res.write(Responder.requestError("review not found"));
res.end();
}
this.logger.log(`${Logger.emp(receiver)} <~ "${req.path}"`);
});